-
-
Notifications
You must be signed in to change notification settings - Fork 3
Closed
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestrubyPull requests that update Ruby codePull requests that update Ruby code
Description
Problem this feature will solve
The code is full or constants. I tried my best so far to avoid magic numbers, but there are still a few of them. Sometimes, magic numbers are extracted into well-named constants, but these constants have to be repeated across files, or fetched from one another creating an unwanted relationship.
Desired solution
Extract and document constants in a dedicated class.
Alternatives considered
Examples:
3600appears multiple times, most of the time to convert decimal hours into seconds, or the oppositeDAYS_PER_JULIAN_CENTURY, currently inAstronoby::Epochwhile not completely relatedSECONDS_PER_HOUR, currently inAstronoby::Anglebut probably necessary elsewhere
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestrubyPull requests that update Ruby codePull requests that update Ruby code