Skip to content

More OOP for observation events #58

@rhannequin

Description

@rhannequin

Based on an original idea from @janfri (see #50).

Problem this feature will solve

RiseTransitSet exposes arrays of data (#times, #azimuths), which are not very clear nor user-friendly.

Desired solution

A more Ruby approach would be to wrap such times and angles into dedicated objects, kind of a presenter of the data produced by the algorithm. This would also enable to have access to all the data, or only a few of them, without the need of memoization for performance.

Alternatives considered

  • Transform RiseTransitSet to return an object with each data in its own method
  • Possibly rename the class
  • Extract twilight times from Sun into a dedicated object with each data in its own method

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestrubyPull requests that update Ruby code

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions