-
-
Notifications
You must be signed in to change notification settings - Fork 3
Closed
Labels
enhancementNew feature or requestNew feature or requestrubyPull requests that update Ruby codePull requests that update Ruby code
Description
Based on an original idea from @janfri (see #50).
Problem this feature will solve
RiseTransitSet exposes arrays of data (#times, #azimuths), which are not very clear nor user-friendly.
Desired solution
A more Ruby approach would be to wrap such times and angles into dedicated objects, kind of a presenter of the data produced by the algorithm. This would also enable to have access to all the data, or only a few of them, without the need of memoization for performance.
Alternatives considered
- Transform
RiseTransitSetto return an object with each data in its own method - Possibly rename the class
- Extract twilight times from
Suninto a dedicated object with each data in its own method
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestrubyPull requests that update Ruby codePull requests that update Ruby code