only fail on template connectPhysicalDisk if storage pool type == FiberChannel

Glover, Rene (rg9975) · Glover, Rene (rg9975) · commit f066100de9e1 · 2025-01-31T13:51:50.000-06:00
diff --git a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
@@ -277,8 +277,12 @@ public Answer copyTemplateToPrimaryStorage(final CopyCommand cmd) {
                 }
 
                 if (path != null && !storagePoolMgr.connectPhysicalDisk(primaryStore.getPoolType(), primaryStore.getUuid(), path, details)) {
-                    s_logger.warn("Failed to connect physical disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());
-                    return new PrimaryStorageDownloadAnswer("Failed to spool template disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());
+                    if (primaryStore.getPoolType() == StoragePoolType.FiberChannel) {
+                        s_logger.warn("Failed to connect physical disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());
+                        return new PrimaryStorageDownloadAnswer("Failed to spool template disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());
+                    } else {
+                        s_logger.warn("Failed to connect physical disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());
+                    }
                 }
 
                 primaryVol = storagePoolMgr.copyPhysicalDisk(tmplVol, path != null ? path : destTempl.getUuid(), primaryPool, cmd.getWaitInMillSeconds());

Original file line number	Diff line number	Diff line change
`@@ -277,8 +277,12 @@ public Answer copyTemplateToPrimaryStorage(final CopyCommand cmd) {`
`277`	`277`	`}`
`278`	`278`
`279`	`279`	`if (path != null && !storagePoolMgr.connectPhysicalDisk(primaryStore.getPoolType(), primaryStore.getUuid(), path, details)) {`
`280`		`- s_logger.warn("Failed to connect physical disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());`
`281`		`- return new PrimaryStorageDownloadAnswer("Failed to spool template disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());`
	`280`	`+ if (primaryStore.getPoolType() == StoragePoolType.FiberChannel) {`
	`281`	`+ s_logger.warn("Failed to connect physical disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());`
	`282`	`+ return new PrimaryStorageDownloadAnswer("Failed to spool template disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());`
	`283`	`+ } else {`
	`284`	`+ s_logger.warn("Failed to connect physical disk at path: " + path + ", in storage pool id: " + primaryStore.getUuid());`
	`285`	`+ }`
`282`	`286`	`}`
`283`	`287`
`284`	`288`	`primaryVol = storagePoolMgr.copyPhysicalDisk(tmplVol, path != null ? path : destTempl.getUuid(), primaryPool, cmd.getWaitInMillSeconds());`