sighash_type made explicit along with a bump in bitcoind version for CI testing
#415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change of default `sighash` type in `bitcoind` was a minor breaking change.
Collaborator
Author
|
Keeping the After looking at cljdocs I changed the value to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Bitcoin Core ignores the sighash type specified inside the PSBT inputs,
sign_psbtrelied on the default value ofsighash_typewhich aligned with our requirements. bitcoin/bitcoin#22514 changed the default value fromSIGHASH_ALLtoSIGHASH_DEFAULT. Makingsighash_typeexplicit fixes the minor breaking change caused by the update in the bitcoin wallet. Note that sincesighashtypeparameter comes after thesignparameter, the value ofsignhas been set to the default value,true.Along with the fix,
bitcoindversion used in CI has been bumped from22.0to23.0.This issue closes #414.