Merged
Conversation
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This also removes the useless test_transaction_creation() test, just added to highlight the API. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Still prep work for PSBT integration Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This avoids confusion, also some slight drive-by doc improvements. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This was coming. PrevOuts can be reused and with the inclusion of the TxOut into them we lost the Copy, intuitively bounding their lifetimes to one usage. Besides, we had those monstruous inputs in RevaultTransactions' new()s. Now that their sequence is bounded to them, they are one-shot transaction inputs, and their usage is much more intuitive! Of course, this helps me with PSBT as well :-) Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This: - Replaces the inner Transaction by a PSBT in RevaultTransaction - Adapts the API to use BIP174 roles (somewhat) - Implements the satisfaction as part of the RevaultTransaction, under the Finalizer role. - Still makes use of our internal satisfier (even though the pub API is now part of RevaultTransaction). - Reuses some logic from Miniscript descriptors until upstream implements comprehensive PSBT support for them. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
We won't finalize a transaction that does not pass the libbitcoinconsensus check. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Fixes revault#19 Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
We don't run on any Github branch anymore ! Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Member
Author
|
Don't know if i missed something. |
JSwambo
approved these changes
Oct 3, 2020
Member
Author
|
Ok, missed the sequence stuff. Merging this and doing a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #21