Check that $SILVER_SHELL env var ends with supported shell name#19
Merged
reujab merged 1 commit intoreujab:masterfrom Sep 12, 2019
Merged
Check that $SILVER_SHELL env var ends with supported shell name#19reujab merged 1 commit intoreujab:masterfrom
reujab merged 1 commit intoreujab:masterfrom
Conversation
Fixes bug that caused a panic in terminal emulators that return the full path for $0 (e.g. "/bin/bash" instead of "bash") when users set $SILVER_SHELL to $0 as instructed. Also adds a more descriptive panic message.
Contributor
Author
|
My first experience with Rust so if there's a better way to go about this, I'd be happy to learn. This just seemed like a clean way to do it without changing the existing code too much. |
Owner
|
The way I would go about this is taking the base file name of Anyway, thanks for the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug that caused a panic in terminal emulators that return the full path for $0 (e.g. "/bin/bash" instead of "bash") when users set $SILVER_SHELL to $0 as instructed. Also adds a more descriptive panic message.
Closes #16