Fix HashMap behaviour when updating == but ne keys#95
Closed
Fix HashMap behaviour when updating == but ne keys#95
Conversation
The test suite that aimed to bring all of our sets and maps into
line did not exercise code paths optimized for:
collection.$op(collectionOfSameType)
This commit updates the test to:
- add test variants that generate operands of the same type as the
input collection
- add "preserves identity" tests for set intersection
- fix the resulting failures by flipping the operands
in `RedBlackTree.{union,intersection}`
I've also added concrete test cases to `Tree{Map,Set}Test` that
are easier to review and that also exercise builders.
58fdde8 to
5151314
Compare
... when the operand overwrites mapping with a key that is == but ne.
This is consistent with the super class implementation, which
was overridden in 2.12.11 for efficiency.
I also found a pair of ClassCastExceptions in the new implementations
of `HashMap.++:`, for instance:
```
case class C(a: Int)(override val toString: String); implicit val Ordering_C: Ordering[C] = Ordering.by(_.a); val c0l = C(0)("l"); val c0r = C(0)("r"); import collection.immutable._; println(HashMap((c0l, ())).++:(TreeMap((c0r, ()))))'; done
v2.12.10
Map(r -> ())
v2.12.11
java.lang.ClassCastException: scala.collection.immutable.HashMap$adder$1$ cannot be cast to scala.collection.immutable.HashMap
at scala.collection.immutable.HashMap$adder$1$.<init>(HashMap.scala:215)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for scala/bug#12047