Skip to content

Review/8749#86

Merged
retronym merged 9 commits intoretronym:review/8749from
mkeskells:review/8749
Mar 1, 2020
Merged

Review/8749#86
retronym merged 9 commits intoretronym:review/8749from
mkeskells:review/8749

Conversation

@mkeskells
Copy link

should fix most of the mima issues

the type hierarchy of class scala.collection.immutable.RedBlackTree#KeysIterator is different in other version. Missing types {scala.collection.AbstractIterator}
                                                                                                                                                        * method --(scala.collection.GenTraversableOnce)scala.collection.immutable.TreeMap in class scala.collection.immutable.TreeMap does not have a correspondent in other version
method keySet()scala.collection.immutable.TreeSet in class scala.collection.immutable.TreeMap does not have a correspondent in other version
method filter(scala.Function1)scala.collection.immutable.TreeMap in class scala.collection.immutable.TreeMap does not have a correspondent in other version
method filter(scala.Function1)scala.collection.immutable.TreeSet in class scala.collection.immutable.TreeSet does not have a correspondent in other version
method ++(scala.collection.GenTraversableOnce)scala.collection.immutable.TreeSet in class scala.collection.immutable.TreeSet does not have a correspondent in other version
method --(scala.collection.GenTraversableOnce)scala.collection.immutable.TreeSet in class scala.collection.immutable.TreeSet does not have a correspondent in other version
method diff(scala.collection.GenSet)scala.collection.immutable.TreeSet in class scala.collection.immutable.TreeSet does not have a correspondent in other version

as default implemntation of diff is to call --, and we optimise for that then I dont think that we need this override
method intersect(scala.collection.GenSet)scala.collection.immutable.TreeSet in class scala.collection.immutable.TreeSet does not have a correspondent in other version

as default implementation of intersect is to call filter, and we optimise for that then I dont think that we need this override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants