feat: make it dual package friendly #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JounQin
commented
Apr 9, 2025
|
|
||
| go 1.24.1 | ||
|
|
||
| require ( |
| "types": "./dist/index.d.ts", | ||
| "default": "./dist/index.js" | ||
| }, | ||
| "module-sync": { |
Owner
Contributor
Author
Could give it a try. |
reteps
requested changes
Apr 9, 2025
Owner
reteps
left a comment
There was a problem hiding this comment.
Lets try a dynamic import before doing this.
| return fs.readFile( | ||
| path.resolve( | ||
| path.dirname(fileURLToPath(import.meta.url)), | ||
| typeof __dirname === 'undefined' |
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "devDependencies": { | ||
| "@pkgr/rollup": "^6.0.2", |
Owner
There was a problem hiding this comment.
I see. Maybe a separate build would work:
https://tduyng.com/blog/dual-package-typescript/
npx tsc -p tsconfig.lib.json --module NodeNext --outDir lib/esm
echo '{"type": "module"}' > lib/esm/package.json
npx tsc -p tsconfig.lib.json --module CommonJS --moduleResolution Node --outDir lib/cjs
echo '{"type": "commonjs"}' > lib/cjs/package.json
echo 'Compilation successful'
I'll see if I can play around with this later.
Contributor
Author
|
No need, this package can be ESM only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close un-ts/prettier#434
cc @reteps