Skip to content

Fix NewDateRegex in StringExtensions #1556#1557

Merged
alexeyzimarev merged 2 commits intorestsharp:devfrom
b-c-ds:bc-doyensec-redos
May 5, 2021
Merged

Fix NewDateRegex in StringExtensions #1556#1557
alexeyzimarev merged 2 commits intorestsharp:devfrom
b-c-ds:bc-doyensec-redos

Conversation

@b-c-ds
Copy link
Contributor

@b-c-ds b-c-ds commented Feb 16, 2021

Description

Fixes #1556.

I think it should be a non-breaking change. Feel free to edit this PR as I don't usually do .NET development.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Previously it had exponential worst-case complexity and was vulnerable to REDoS.
@alexeyzimarev alexeyzimarev merged commit be39346 into restsharp:dev May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CVE-2021-27293: Fix NewDateRegex

2 participants