Show progress for restic stats#5705
Conversation
4b5f2db to
eacc9e8
Compare
eacc9e8 to
4ec0807
Compare
MichaelEischer
left a comment
There was a problem hiding this comment.
Thanks for working on this. This will unfortunately need quite a bit of changes, see the comments for details.
5d06390 to
2a335d9
Compare
2a335d9 to
fd5b92e
Compare
|
@MichaelEischer |
MichaelEischer
left a comment
There was a problem hiding this comment.
I;ve found a few more small problems, besides those LGTM.
397ee2e to
b444d94
Compare
b444d94 to
0064e13
Compare
|
Hi, Just upgraded to 0.19.0 with this change. However I think not showing the progress bar when --quiet or in non-interactive consoles was missed. Restic docs say: "Subcommands that support showing progress information such as backup, restore, check and prune will do so unless the quiet flag -q or --quiet is set. When running from a non-interactive console progress reporting is disabled by default to not fill your logs. For interactive and non-interactive consoles the environment variable RESTIC_PROGRESS_FPS can be used to control the frequency of progress reporting. Use for example 0.016666 to only update the progress once per minute." Example of this not working: (tried with both -q and --quiet) I can open another issue if desired. |
What does this PR change? What problem does it solve?
restic statsnow displays progress for how many snapshots, files, and blobs were processed so far.This lets users better understand if the command is working as expected or where it is hanging.
Was the change previously discussed in an issue or on the forum?
Closes #5689
Checklist
- [ ] I have added tests for all code changes.- [ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).