Skip to content

fail if RESTIC_READ_CONCURRENCY or RESTIC_COMPRESSION are invalid#5700

Merged
MichaelEischer merged 1 commit into
restic:masterfrom
MichaelEischer:err-invalid-env
May 9, 2026
Merged

fail if RESTIC_READ_CONCURRENCY or RESTIC_COMPRESSION are invalid#5700
MichaelEischer merged 1 commit into
restic:masterfrom
MichaelEischer:err-invalid-env

Conversation

@MichaelEischer

@MichaelEischer MichaelEischer commented Feb 1, 2026

Copy link
Copy Markdown
Member

What does this PR change? What problem does it solve?

Return an error if RESTIC_READ_CONCURRENCY or RESTIC_COMPRESSION cannot be parsed and they haven't been overwritten via their command line option.

Was the change previously discussed in an issue or on the forum?

Follow-up to #5592
Fixes #4759

Checklist

  • I have added tests for all code changes.
  • [ ] I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I'm done! This pull request is ready for review.

@MichaelEischer MichaelEischer changed the title fail of RESTIC_READ_CONCURRENCY or RESTIC_COMPRESSION are invalid fail if RESTIC_READ_CONCURRENCY or RESTIC_COMPRESSION are invalid May 9, 2026

@MichaelEischer MichaelEischer left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelEischer MichaelEischer merged commit 39084a9 into restic:master May 9, 2026
11 checks passed
@MichaelEischer MichaelEischer deleted the err-invalid-env branch May 9, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid environment variable values silently ignored

1 participant