ui: don't rewrite unchanged lines in status bar#5648
Merged
Conversation
MichaelEischer
approved these changes
May 14, 2026
MichaelEischer
left a comment
Member
There was a problem hiding this comment.
LGTM.
I've factored the termstatus code a bit further to keep the whole unchanged handling inside skipUnchanged.
Check if each line of status is changed, and write the line to the terminal only if it has changed
99b0788 to
d494e37
Compare
Member
|
(Rebased and squashed a few commits) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Previously, status bars were entirely rewritten every frame if any of its content has updated.
This behavior had made any user interaction (such as selection) with status bar
impossible in certain terminal emulators, even on the unchanged lines.
Now it writes only changed lines at status bar update, thereby improving
user experience in those terminal emulators.
It is tested in Ubuntu.24.04.3 with st 0.9.3.
Was the change previously discussed in an issue or on the forum?
Closes #5562
Checklist
changelog/unreleased/that describes the changes for our users (see template).