repository: fix LookupBlobSize to also return pending blobs#5614
Merged
Conversation
Merged
4 tasks
MichaelEischer
commented
Nov 26, 2025
Member
Author
There was a problem hiding this comment.
LGTM.
Should have been merged before #5472 . But let's merge the tests anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Extracted from #5472 as this is relevant independent of that PR. This change isn't really user visible. At the moment this could only result in a few warnings less from the
backupcommand when it reuploads missing blobs. All other places that write to a repository don't rely on knowing about pending blobs so far.Was the change previously discussed in an issue or on the forum?
Extracted from #5472
Checklist
[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).