snapshots: Show timezone in non-compact output#5588
Merged
Conversation
MichaelEischer
requested changes
Nov 17, 2025
MichaelEischer
left a comment
Member
There was a problem hiding this comment.
Nice, I like the overall approach, I just have to nits commented below. Please add a short changelog entry (see changelog/TEMPLATE)
8521d57 to
dc4e9b3
Compare
Author
|
Thanks! Did the changes and added a changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Restic lists snapshots in user's current timezone. It's very convenient but might be confusing in case of multiple users accessing the same repository without realizing they're on different timezones.
This change is an attempt to solve it by showing one-line information to the bottom of the snapshot list (plus, it is a best effort trying to get the timezone info, since I am not sure how reliable would this method be on non-Linux operating systems).
Was the change previously discussed in an issue or on the forum?
https://forum.restic.net/t/timezone-question/10228
Checklist
changelog/unreleased/that describes the changes for our users (see template).