repository: enforce correct usage of SaveBlob#5558
Merged
MichaelEischer merged 2 commits intoNov 16, 2025
Conversation
The new method combines both step into a single wrapper function. Thus it ensures that both are always called in pairs. As an additional benefit this slightly reduces the boilerplate to upload blobs.
This is achieved by removing SaveBlob from the public API and only returning it via a uploader object that is passed in by WithBlobUploader.
65e1168 to
c6e33c3
Compare
4 tasks
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Uploading new blobs requires quite bit of boilerplate code. To reduce it replace StartPackUploader+Flush with WithBlobUploader . The latter handles the setup and flushing automatically.
Then move the SaveBlob method into the helper returned by WithBlobUploader. This ensures that SaveBlob cannot be called while the repository is not ready for it (well, strictly speaking the callback passed to WithBlobUploader could leak a reference to SaveBlob. However, there's no way to statically enforce this in Go).
Was the change previously discussed in an issue or on the forum?
No. Noticed this while making preparations for #2446 .
Checklist
[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).