feat: allow override env RESTIC_HOST with flag to filter all snapshots#5541
Merged
MichaelEischer merged 8 commits intoOct 5, 2025
Conversation
MichaelEischer
requested changes
Oct 3, 2025
MichaelEischer
left a comment
Member
There was a problem hiding this comment.
LGTM in general, except for the nits below:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
When the
RESTIC_HOSTenvironment variable was set, there was no way to list or operate on snapshots from all hosts, as the environment variable would always filter to that specific host.With these changes specifying
--host=""will filter snapshots from all hosts.To maintain consistency I have updated the following commands that support snapshot filtering:
snapshots,forget,find,stats,copy,tag,repair snapshots,rewrite,mount,restore,dump, andls.Disclaimer:
I have used the AI IDE Cursor to help me with the repetitive changes across all the commands and the unit tests for these changes.
Was the change previously discussed in an issue or on the forum?
Closes #5440
Checklist
changelog/unreleased/that describes the changes for our users (see template).