Replace Repository.SetIndex with internal helper#5532
Merged
Conversation
78d74ee to
ea8f443
Compare
ea8f443 to
4426dfe
Compare
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Repository.SetIndexis only used by theCheckercode andRepairIndex. To allow convertingSetIndexinto a repository internal API, first split the checker into two parts: one that checks packs+index and another that checks the snapshot, tree and blob structure. ThenSetIndexis replaced byloadIndexWithCallbackwhich allows ignoring index load errors and inspecting the loaded indexes.Was the change previously discussed in an issue or on the forum?
No.
Checklist
I have added tests for all code changes.No new tests. Keeping the tests in thecheckerpackage, but moving a lot of code to therepositorypackage isn't ideal, but I didn't find a good line along which to split the code.[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).