check: fix error reporting on download retry#5495
Merged
MichaelEischer merged 2 commits intorestic:masterfrom Sep 15, 2025
Merged
check: fix error reporting on download retry#5495MichaelEischer merged 2 commits intorestic:masterfrom
MichaelEischer merged 2 commits intorestic:masterfrom
Conversation
24c0639 to
67a24c9
Compare
67a24c9 to
de29d74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Reset all blob decoding errors in a pack file when retrying the download. We're only interested in the result for the last attempt as otherwise the overall pack file hash check and the blob errors are inconsistent with each other.
For a perfect backend, this shouldn't make any difference as the backend would only ever return incomplete data but never garbage data. Hence the checks inside the
Load(...)call wouldn't report errors. But if the first incomplete attempt returned garbage data but the second attempt was successful, thencheckwould report an error for individual blobs, but not the overall pack file. This is highly confusing.Was the change previously discussed in an issue or on the forum?
Partially addresses #5467
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).