Skip to content

Refactor terminal background handling#5494

Merged
MichaelEischer merged 12 commits into
restic:masterfrom
MichaelEischer:fix-background-handling
Sep 13, 2025
Merged

Refactor terminal background handling#5494
MichaelEischer merged 12 commits into
restic:masterfrom
MichaelEischer:fix-background-handling

Conversation

@MichaelEischer

@MichaelEischer MichaelEischer commented Sep 7, 2025

Copy link
Copy Markdown
Member

What does this PR change? What problem does it solve?

Consolidate most code that directly interacts with a terminal into internal/terminal.

Was the change previously discussed in an issue or on the forum?

Follow up to #5358 and #5493

Checklist

  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I'm done! This pull request is ready for review.

Comment thread internal/terminal/shell_split.go
@MichaelEischer MichaelEischer force-pushed the fix-background-handling branch 2 times, most recently from dd656d6 to 31fad2e Compare September 8, 2025 08:58
@MichaelEischer MichaelEischer marked this pull request as ready for review September 8, 2025 08:58
@MichaelEischer MichaelEischer force-pushed the fix-background-handling branch from 31fad2e to 424316e Compare September 8, 2025 09:05

@MichaelEischer MichaelEischer left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelEischer MichaelEischer merged commit f21fd9d into restic:master Sep 13, 2025
11 checks passed
@MichaelEischer MichaelEischer deleted the fix-background-handling branch September 13, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants