Mark HTTP Error 507 as permanent#5452
Merged
MichaelEischer merged 2 commits intorestic:masterfrom Sep 5, 2025
Merged
Conversation
This change classifies HTTP error 507 (Insufficient Storage) as a permanent error that should not be retried. I keep running into this once in a while and there is literally no point in retrying when the server is full. Fixes restic#5429 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
5e1be33 to
5c17c27
Compare
MichaelEischer
approved these changes
Sep 5, 2025
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM.
I've rebased the PR and added a changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change classifies HTTP error 507 (Insufficient Storage) as a permanent error that should not be retried. I keep running into this once in a while and there is literally no point in retrying when the server is full.
Fixes #5429