backup: fix possible crash if directory disappears before metadata collection#5421
Merged
MichaelEischer merged 6 commits intorestic:masterfrom Sep 5, 2025
Merged
Conversation
4da5fb3 to
64df0b6
Compare
5 tasks
this could crash in two cases: - if a directory is deleted between restic stating it and trying to list its directory content. - when restic tries to list the parent directory of a backup target, but the parent directory has been deleted. return an error in this case instead.
Handle errors for parent directories of backup directories in the same way as all other file access errors during a backup.
4957dad to
484b706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Fix a crash during the backup in nodeFromFileInfo in two cases:
A backup also no longer completely fails if a parent folder becomes inaccessible during the backup. This only becomes relevant with the above crash fix as this scenario most likely results in a crash in restic 0.18.0.
The general idea is to also handle errors for parent directories of backup directories in the same way as all other file access errors during a backup.
Was the change previously discussed in an issue or on the forum?
Partially addresses #5391 .
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).