Bugfix restic find: missing check for mtime --oldest/--newest#5310
Conversation
|
I have decided to revert this PR to closed status to ease the pressure on the |
I'd actually prefer to keep the PRs open to give me the chance to decided which PRs appear more important to me. |
Michael, it would be good to know your priorities. Then I could work along these important issues. Thanks! |
3e2c96c to
3b5bbde
Compare
restic find: missing check for mtime oldest/newest - issue #5280
restic find: missing check for mtime oldest/newest - issue #5280restic find: missing check for mtime --oldest/--newest
Add new backup-data.tar.gz which includes in directory 0/0/7 51 files with a mtime date range from 2014 to 2025. Add missing check for `--oldest` >= `--newest`. Add test which checks for `--oldest` >= `--newest`.
cmd/restic/testdata/backup-data.tar.gz: converted to standard test repository cmd/restic/cmd_find_integration_test.go: added missing parameter for 'term'
b07db3e to
f5aa794
Compare
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
I've reworded the error message and the changelog a bit. The test is now also a lot closer. The error is also thrown for an empty repository, so there's no need to create an actual snapshot.
Add new backup-data.tar.gz which includes in directory 0/0/7 51 files with a mtime date range from 2014 to 2025.
Add missing check for
--oldest>=--newest.Add test which checks for
--oldest>=--newest.What does this PR change? What problem does it solve?
This PR fixes and issue described in #5280 and fixes the missing test for
--oldest>=--newest.Was the change previously discussed in an issue or on the forum?
See #5280
Checklist
- [ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).