Randomize blob to pack file assignment#5295
Merged
MichaelEischer merged 5 commits intorestic:masterfrom Mar 25, 2025
Merged
Conversation
This prevents chunk size leaks when a backup only consists of a small file which is split in two parts, which end up in two individual pack files.
7a261e9 to
e95be5e
Compare
e95be5e to
ccb92f5
Compare
rawtaz
previously requested changes
Mar 24, 2025
Contributor
rawtaz
left a comment
There was a problem hiding this comment.
Slight documentation change, other than that I have no comments 🍦
Co-authored-by: rawtaz <rawtaz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Implement mitigation described in #5291 (comment)
Was the change previously discussed in an issue or on the forum?
See #5291 (comment)
Checklist
changelog/unreleased/that describes the changes for our users (see template).