mount: append the repository ID to the name of the FUSE mount#5243
Merged
MichaelEischer merged 2 commits intoApr 2, 2025
Merged
Conversation
MichaelEischer
requested changes
Mar 22, 2025
MichaelEischer
left a comment
Member
There was a problem hiding this comment.
The id part should match that printed in the "created restic repository %v at %s" messages.
c328f45 to
3a22af9
Compare
Contributor
Author
|
This is ready for review. |
Member
|
Please add a changelog entry. I had something like the following in mind: (the inner part is in triple backticks) $ df ./test-mount/ |
* update review comments mount: append repository ID to FS name of the FUSE mount
3a22af9 to
6db0d84
Compare
Contributor
Author
|
@MichaelEischer I have added the changelog entry as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Append the repository ID to the name of the FUSE mount created using the restic
mountcommand. When the user is mounting multiple repositories, this makes it easier to understand which repository is mounted where.[Edit]
Example output:
In the above example the ID
d3b07384d1is appended to the filesystem name. This is the first 10 characters of the repository ID.[/Edited]
Was the change previously discussed in an issue or on the forum?
Closes #4868
Checklist
changelog/unreleased/that describes the changes for our users (see template).