func ParallelRemove(ctx context.Context, repo RemoverUnpacked, fileList IDSet, fileType FileType, report func(id ID, err error) error, bar *progress.Counter) error {

Hey @MichaelEischer,

I want to remove the dependence on *progress.Counter from here, I believe the report function can update the bar as well since it's a dependency injected from outside.

This will allow restic internal methods to be tested independently of the progress reporting.

I don't understand the testing argument. In fact the test case no longer tests the behavior of ParallelRemove but rather of ParallelRemove + custom progress bar calls in report function. For consistent behavior, it feels more reasonable to have progress bar updates handled by ParallelRemove. I don't see a technical reason why that wouldn't work.

I was thinking that the reporting and progress counters must be together. I can revert the change to the fix I had made earlier.

Thanks for the review. I will think about this more before making any major changes.

I was thinking that the reporting and progress counters must be together. I can revert the change to the fix I had made earlier.

Yes, please revert the changes from 94ad25e . The implementation from 5e64578 is what I had in mind. The added tests should still work with minor modifications.

I don't think it's worth the trouble to introduce other abstractions, let's just keep using the progress counter.

The added tests should still work with minor modifications.

I have made the modifications, let me know if I have missed something.

We can address the concerns on a separate PR after discussion.