Skip to content

backup: Ignore disappeared files#5145

Merged
MichaelEischer merged 2 commits intorestic:masterfrom
MichaelEischer:ignore-disappeared-files
Nov 30, 2024
Merged

backup: Ignore disappeared files#5145
MichaelEischer merged 2 commits intorestic:masterfrom
MichaelEischer:ignore-disappeared-files

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer commented Nov 16, 2024

What does this PR change? What problem does it solve?

Ignore "No such file" errors when trying to save a file in the archiver. This PR includes #5143 and only adds a single commit. Making the PRs independent is unfortunately not possible as it would require a reimplementation of this PR, which would soon become obsolete.

This PR only fixes the "No such file" error in regards to lstat (probably the most common), but not the Listxattr errors later on. Those require a file-handle-based implementation that has to wait for a followup PR.

Was the change previously discussed in an issue or on the forum?

Fixes part of #3098
Fixes part of #2165

Checklist

  • I have added tests for all code changes.
  • [ ] I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I'm done! This pull request is ready for review.

@MichaelEischer MichaelEischer force-pushed the ignore-disappeared-files branch from 45864e3 to c5fb46d Compare November 30, 2024 14:31
Copy link
Copy Markdown
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Depending on the change packages, the VSS tests from ./cmd/restic and
the fs package may overlap in time. This causes the snapshot creation to
fail. Add retries in that case.
@MichaelEischer MichaelEischer merged commit 806fa53 into restic:master Nov 30, 2024
@MichaelEischer MichaelEischer deleted the ignore-disappeared-files branch November 30, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant