Skip to content

tag: output the original ID and new snapshotID#5144

Merged
MichaelEischer merged 4 commits intorestic:masterfrom
zmanda:fix-gh-5137-tags-cmd-output-changed-snapshotID
Jan 14, 2025
Merged

tag: output the original ID and new snapshotID#5144
MichaelEischer merged 4 commits intorestic:masterfrom
zmanda:fix-gh-5137-tags-cmd-output-changed-snapshotID

Conversation

@konidev20
Copy link
Copy Markdown
Contributor

@konidev20 konidev20 commented Nov 16, 2024

What does this PR change? What problem does it solve?

This PR adds the ability of the restic tag command to return the modified snapshot ID when the tag command is run.

Was the change previously discussed in an issue or on the forum?

Closes #5137

Checklist

  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I'm done! This pull request is ready for review.

@konidev20 konidev20 force-pushed the fix-gh-5137-tags-cmd-output-changed-snapshotID branch from 3928222 to 222d505 Compare December 14, 2024 20:25
@konidev20 konidev20 marked this pull request as ready for review December 14, 2024 20:37
@konidev20 konidev20 force-pushed the fix-gh-5137-tags-cmd-output-changed-snapshotID branch from 7bbdd91 to 9a2d3a0 Compare December 15, 2024 06:49
@konidev20 konidev20 force-pushed the fix-gh-5137-tags-cmd-output-changed-snapshotID branch from 5d1cda5 to 02ff018 Compare December 24, 2024 10:20
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes so far and sorry for the late review. I have a few more small nits.

tag: print changed snapshot information immediately

* print changed snapshot immediately after it has been saved
* add message type to the changedSnapshot
* add a summary type which will share the JSON output of the numer of changed snapshots
* updated verbosity of the changed snapshot in text mode to only work when verbosity > 2
* also use the terminal status printer for a standard handling for stdout messages

docs: add json schema for tag command
@konidev20 konidev20 force-pushed the fix-gh-5137-tags-cmd-output-changed-snapshotID branch from 02ff018 to 537a040 Compare January 14, 2025 14:08
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output new snapshot ID whenever the tag command causes an existing ID to change

2 participants