Return error if AZURE_ACCOUNT_NAME not set#5141
Merged
MichaelEischer merged 2 commits intorestic:masterfrom Dec 1, 2024
richgrov:missing-azure-env-error
Merged
Return error if AZURE_ACCOUNT_NAME not set#5141MichaelEischer merged 2 commits intorestic:masterfrom richgrov:missing-azure-env-error
MichaelEischer merged 2 commits intorestic:masterfrom
richgrov:missing-azure-env-error
Conversation
Contributor
Author
|
@MichaelEischer hate to bother you, but is there anything else I need to do before this can be reviewed? |
MichaelEischer
approved these changes
Dec 1, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
@MichaelEischer hate to bother you, but is there anything else I need to do before this can be reviewed?
No, I just haven't found time for a PR review. I just too busy finally finishing one of my massive fs refactoring PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Due to
AZURE_ACCOUNT_NAMEnot being set, this error can occur when trying to reach a repository:Was the change previously discussed in an issue or on the forum?
This is not tied to a previous issue, as it is a simple fix. An explicit check is added which now produces a message like this:
Checklist
changelog/unreleased/that describes the changes for our users (see template).