fs: fallback to low privilege security descriptors on access denied#5123
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Nov 3, 2024
Merged
Conversation
This was referenced Nov 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
For some reason the
ERROR_PRIVILEGE_NOT_HELDerror is not returned for removable media but instead anaccess deniederror is returned. Workaround that by just retrying with the low privilege version, but don't switch privileges as we cannot distinguish this case from actual access denied errors. See #5003 (comment) for detailsThere are NO new test cases as testing this mess would require setting up some virtual removable media, which completely exceeds the scope of our tests.
Was the change previously discussed in an issue or on the forum?
Fixes #5003
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.