Skip to content

backup: include start and end time in json output#5119

Merged
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:backup-json-start-end-time
Nov 11, 2024
Merged

backup: include start and end time in json output#5119
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:backup-json-start-end-time

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer commented Nov 1, 2024

What does this PR change? What problem does it solve?

The timestamps were already stored in the created snapshot. Thus also add them to the json output of the backup command for consistency.

Was the change previously discussed in an issue or on the forum?

https://forum.restic.net/t/understanding-snapshot-summaries-and-stats-ouput/8467/3

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@MichaelEischer MichaelEischer force-pushed the backup-json-start-end-time branch from a61212e to e7d9c69 Compare November 1, 2024 15:04
The timestamps were already stored in the created snapshot.
@MichaelEischer MichaelEischer force-pushed the backup-json-start-end-time branch from e7d9c69 to e65f4e2 Compare November 1, 2024 15:31
Copy link
Copy Markdown
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MichaelEischer MichaelEischer merged commit 9c75831 into restic:master Nov 11, 2024
@MichaelEischer MichaelEischer deleted the backup-json-start-end-time branch November 11, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant