Skip to content

sftp: check for broken connection in Load/List operation#5101

Merged
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:sftp-load-error
Nov 1, 2024
Merged

sftp: check for broken connection in Load/List operation#5101
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:sftp-load-error

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer commented Oct 21, 2024

What does this PR change? What problem does it solve?

The Load and List operations of the sftp backend did not explicitly check whether the server connection is broken. This causes restic to retry "connection lost" errors for those operations.

Was the change previously discussed in an issue or on the forum?

Showed up in https://forum.restic.net/t/restic-hanging-on-backup/8559/2

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@MichaelEischer MichaelEischer merged commit ded9fc7 into restic:master Nov 1, 2024
@MichaelEischer MichaelEischer deleted the sftp-load-error branch November 1, 2024 15:05
@MichaelEischer MichaelEischer mentioned this pull request Nov 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants