sftp: check for broken connection in Load/List operation#5101
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Nov 1, 2024
Merged
sftp: check for broken connection in Load/List operation#5101MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer merged 1 commit intorestic:masterfrom
Conversation
greatroar
approved these changes
Oct 27, 2024
8a168b0 to
71c1853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The
LoadandListoperations of the sftp backend did not explicitly check whether the server connection is broken. This causes restic to retry "connection lost" errors for those operations.Was the change previously discussed in an issue or on the forum?
Showed up in https://forum.restic.net/t/restic-hanging-on-backup/8559/2
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.