backup: read extended metadata from snapshot#5097
Merged
MichaelEischer merged 9 commits intorestic:masterfrom Oct 22, 2024
Merged
backup: read extended metadata from snapshot#5097MichaelEischer merged 9 commits intorestic:masterfrom
MichaelEischer merged 9 commits intorestic:masterfrom
Conversation
Previously, NodeFromFileInfo used the original file path to create the node, which also meant that extended metadata was read from there instead of within the vss snapshot.
OpenFile, Stat and Lstat should reuse the underlying FS implementation to avoid diverging behavior.
8cf779b to
ff006c6
Compare
When using the VSS FS, then `f.Name()` contained the filename in the snapshot. This caused a double mapping when calling NodeFromFileInfo.
The only user was archiver.fileSaver.
a02f6bd to
fc6f1b4
Compare
This was referenced Oct 18, 2024
|
Backups failing with 0.17.2 Reverted to 0.17.1 and backups are working again. |
This was referenced Oct 30, 2024
Member
Author
|
See #5107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
When creating a
backupusing VSS, the extended file metadata was not read from the snapshot but instead from the original. This can cause errors if the original file has been removed in the meantime.The
LocalVssnow correctly intercepts the path passed toNodeFromFileInfo. This change is complemented with a bunch of tests to ensure that all paths are correctly intercepted.Was the change previously discussed in an issue or on the forum?
Fixes #5063
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.