fs: fix restoring timestamps on older Windows versions for long paths#5061
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Oct 16, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Go automagically enables long-path support on Windows 10 >=1607 (see golang/go#41734). The standard library calls are also wrapped accordingly to support older Windows versions. However, for some filesystem operations we have to use the syscalls package directly which does not wrap paths.
Most places should already contain a corresponding
fixpath(...)call, this PR fixes restoring the timestamp and file attributes.Was the change previously discussed in an issue or on the forum?
Fixes #1843
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.