Skip to content

fs: move NodeFromFileInfo into FS interface#5060

Merged
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:proper-nodefromfileinfo
Oct 16, 2024
Merged

fs: move NodeFromFileInfo into FS interface#5060
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:proper-nodefromfileinfo

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

What does this PR change? What problem does it solve?

Move NodeFromFileInfo into FS interface. With this change the archiver code performs all filesystem interactions via the FS interface. This now also allows removing hacks that were necessary to generate a restic.Node from a fs.Reader filesystem.

Was the change previously discussed in an issue or on the forum?

Part of #5021

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • [ ] I have added tests for all code changes.
  • [ ] I have added documentation for relevant changes (in the manual).
  • [ ] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@MichaelEischer MichaelEischer force-pushed the proper-nodefromfileinfo branch from e8fcdaa to 7571144 Compare October 16, 2024 19:18
Copy link
Copy Markdown
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MichaelEischer MichaelEischer merged commit bcd5ac3 into restic:master Oct 16, 2024
@MichaelEischer MichaelEischer deleted the proper-nodefromfileinfo branch October 16, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant