Skip to content

tag: fix swallowed error if repository cannot be opened#5056

Merged
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:fix-tag-error-handling
Oct 9, 2024
Merged

tag: fix swallowed error if repository cannot be opened#5056
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:fix-tag-error-handling

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer commented Sep 14, 2024

What does this PR change? What problem does it solve?

tag did not return an error if opening or locking the repository failed.

Was the change previously discussed in an issue or on the forum?

Fixes #5050

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Copy Markdown
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MichaelEischer MichaelEischer merged commit 7839017 into restic:master Oct 9, 2024
@MichaelEischer MichaelEischer deleted the fix-tag-error-handling branch October 9, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set tag in a locked repo tries to unlock and fails without error message

2 participants