generate: allow passing - for stdout output#5053
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Oct 9, 2024
Merged
generate: allow passing - for stdout output#5053MichaelEischer merged 1 commit intorestic:masterfrom
- for stdout output#5053MichaelEischer merged 1 commit intorestic:masterfrom
Conversation
1 task
MichaelEischer
requested changes
Sep 14, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
The check for - should move into the write*Completion functions. That will require a few more changes to avoid additional code duplication, see the comments below.
Since generating completions to stdout for multiple shells does not make sense, enforce `-` is supplied only once.
5bd8e29 to
3d97656
Compare
Contributor
Author
|
Thank you for your review! I applied your suggestions with some minor modifications to make the code compile. |
MichaelEischer
approved these changes
Oct 9, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. Sorry for the delayed review and thanks for improving the generate command!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Allow generating shell completions to stdout by supplying
-as file name. Since generating completions to stdout for multiple shells does not make sense, enforce-is supplied only once.Was the change previously discussed in an issue or on the forum?
Closes #2511.
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.