Skip to content

azure: add support for access tiers hot, cool and cold#5046

Merged
MichaelEischer merged 2 commits intorestic:masterfrom
konidev20:fix-gh-4521-azure-blob-storage-add-support-for-access-tiers
Nov 11, 2024
Merged

azure: add support for access tiers hot, cool and cold#5046
MichaelEischer merged 2 commits intorestic:masterfrom
konidev20:fix-gh-4521-azure-blob-storage-add-support-for-access-tiers

Conversation

@konidev20
Copy link
Copy Markdown
Contributor

@konidev20 konidev20 commented Sep 8, 2024

What does this PR change? What problem does it solve?

This commit adds functionality to control the access tier for Azure blob storage backend. This should support Online Access Tiers including Hot, Cool and Cold.

Only Data Pack files which are infrequently accessed will be stored in the selected access tier.

Was the change previously discussed in an issue or on the forum?

Closes #4521

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@konidev20 konidev20 marked this pull request as draft September 14, 2024 08:54
@konidev20 konidev20 force-pushed the fix-gh-4521-azure-blob-storage-add-support-for-access-tiers branch 2 times, most recently from 97669f6 to 4869b4a Compare September 29, 2024 18:12
@konidev20 konidev20 marked this pull request as ready for review September 29, 2024 18:37
@greatroar
Copy link
Copy Markdown
Contributor

Are we sure that allowing the archive tier is a good idea? It's latency can be on the order of hours, say the MS docs, so this seems to introduce a cold storage option without special support for getting the data back out. I mean, maybe you can set timeouts to multiple hours, but does that not cause other trouble?

Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that allowing the archive tier is a good idea? It's latency can be on the order of hours, say the MS docs, so this seems to introduce a cold storage option without special support for getting the data back out.

The archive tier definitely shouldn't be officially documented as supported. Right now, the S3 backend also allows setting arbitrary storage classes (including glacier / deep archive) but those are never explicitly mentioned in the documentation. Instead the changelog entry from https://github.com/restic/restic/pull/4584/files makes is clear that cold storage is not officially supported and may require manually warming up everything.

@konidev20 konidev20 force-pushed the fix-gh-4521-azure-blob-storage-add-support-for-access-tiers branch from b16f0b6 to bff3341 Compare October 20, 2024 09:57
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MichaelEischer MichaelEischer merged commit 1133498 into restic:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft Azure Blob Storage support access tier

3 participants