Skip to content

backup: support specifying volume instead of path on Windows#5028

Merged
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:windows-allow-specifying-volumes
Aug 31, 2024
Merged

backup: support specifying volume instead of path on Windows#5028
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:windows-allow-specifying-volumes

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer commented Aug 30, 2024

What does this PR change? What problem does it solve?

Allows restic backup C: to create proper snapshots.

Was the change previously discussed in an issue or on the forum?

Fixes #2004
Fixes https://forum.restic.net/t/backup-mounted-veracrypt-volumes/8372

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • [ ] I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@MichaelEischer MichaelEischer force-pushed the windows-allow-specifying-volumes branch from 927bf3c to 4fcedb4 Compare August 30, 2024 09:35
Copy link
Copy Markdown
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MichaelEischer MichaelEischer merged commit a553334 into restic:master Aug 31, 2024
@MichaelEischer MichaelEischer deleted the windows-allow-specifying-volumes branch August 31, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restic backup of root of a drive letter on windows refuses to restore properly

1 participant