Skip to content

Make timeout for slow requests configurable#5014

Merged
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:configurable-slow-request-timeout
Aug 29, 2024
Merged

Make timeout for slow requests configurable#5014
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:configurable-slow-request-timeout

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

What does this PR change? What problem does it solve?

Restic 0.17.0 introduced monitoring for stuck backend requests. This works well in general, however, for busy backends or very large repositories, the timeout can be too low.

Was the change previously discussed in an issue or on the forum?

Fixes #4970
Workaround for #4988

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Copy Markdown
Contributor

@rawtaz rawtaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some small changes.

@MichaelEischer MichaelEischer force-pushed the configurable-slow-request-timeout branch 2 times, most recently from b381ee0 to 3899ec4 Compare August 26, 2024 11:16
@MichaelEischer MichaelEischer force-pushed the configurable-slow-request-timeout branch from 3899ec4 to b8f4097 Compare August 26, 2024 12:14
@MichaelEischer
Copy link
Copy Markdown
Member Author

Renamed --slow-request-timeout to --stuck-request-timeout.

Copy link
Copy Markdown
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelEischer MichaelEischer merged commit 7bbf752 into restic:master Aug 29, 2024
@MichaelEischer MichaelEischer deleted the configurable-slow-request-timeout branch August 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[backend-error-redesign] "context canceled" issues due to timeouts

2 participants