cache: clear snapshot files from cache during load index#4981
Merged
MichaelEischer merged 8 commits intorestic:masterfrom Aug 16, 2024
Merged
Conversation
konidev20
commented
Aug 4, 2024
MichaelEischer
requested changes
Aug 10, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
I don't want to introduce an extra List call to backends just to clean up old snapshots.
8ebfd58 to
a48baf6
Compare
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
The approach looks fine in general, I just have a few small remarks on it. Other than that only a test and changelog entry are missing.
* removes files which are no longer in the repository, including index files, snapshot files and pack files from the cache. cache: fix ids set initialisation with NewIDSet()
* remove the prepareCache method from the Repository * changed the signature of the SetIndex function to no longer return an error
8c72054 to
5fd984b
Compare
MichaelEischer
requested changes
Aug 15, 2024
…tory" This reverts commit 720609f.
addressing code review comments
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
clear snapshot files from cache during repository preparation.
Was the change previously discussed in an issue or on the forum?
There is a function in
repository.gocalledprepareCache()which is used to clean up old index and pack files from the local cache. This method is called duringLoadIndex.Closes #4934
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.