Skip to content

fix panic in fs_reader#4976

Merged
MichaelEischer merged 1 commit intorestic:masterfrom
textaligncenter:backup-panic
Aug 3, 2024
Merged

fix panic in fs_reader#4976
MichaelEischer merged 1 commit intorestic:masterfrom
textaligncenter:backup-panic

Conversation

@textaligncenter
Copy link
Copy Markdown
Contributor

@textaligncenter textaligncenter commented Aug 3, 2024

What does this PR change? What problem does it solve?

It prevent's panic on using the restic backup --stdin-from-command without a command at the end

Was the change previously discussed in an issue or on the forum?

no

Closes #4975

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! I have one minor nitpick, see below.

Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MichaelEischer MichaelEischer added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@MichaelEischer MichaelEischer added this pull request to the merge queue Aug 3, 2024
Merged via the queue into restic:master with commit a48baf6 Aug 3, 2024
@textaligncenter textaligncenter deleted the backup-panic branch August 3, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic while using --stdin-from-command

2 participants