restore: clean up error handling when restoring metadata#4958
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Aug 3, 2024
Merged
restore: clean up error handling when restoring metadata#4958MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer merged 1 commit intorestic:masterfrom
Conversation
- Fix a logic error that instead of reporting the *first* metadata-setting error that appears, we were instead reporting the *last* error (and only if the lchown call failed!). - Don't show any errors when setting metadata for files in non-root mode (things like timestamps, attributes). Previously, only lchown errors were skipped. But other kinds of attribute errors make sense to skip as well. The code path happened to work correctly before because of the above logic error. But once that was fixed, this change needed to happen too.
8 tasks
MichaelEischer
approved these changes
Aug 3, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for finding and fixing this very old bug!
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Was the change previously discussed in an issue or on the forum?
No - but it's a break out of #4946
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.