Bump go version to 1.21#4938
Merged
MichaelEischer merged 5 commits intorestic:masterfrom Aug 10, 2024
Merged
Conversation
1cb2ef0 to
5c49a0b
Compare
The std library now also supports the sha assembly instructions on ARM64. Thus, sha256-simd no longer provides a performance benefit.
5c49a0b to
400ae55
Compare
|
Does crypto/sha256 work with processors without SSE4 and AVX?
|
Member
Author
I'd expect so. As you seem to have access to such an old CPU, just run |
$ ver && go version
Microsoft Windows [Version 6.1.7601]
go version go1.23.6 windows/amd64
$ go test -bench . crypto/sha256
goos: windows
goarch: amd64
pkg: crypto/sha256
cpu: Intel(R) Core(TM)2 Duo CPU T7250 @ 2.00GHz
BenchmarkHash8Bytes/New-2 1653452 728.7 ns/op 10.98 MB/s 0 B/op 0 allocs/op
BenchmarkHash8Bytes/Sum224-2 1688442 707.6 ns/op 11.31 MB/s 0 B/op 0 allocs/op
BenchmarkHash8Bytes/Sum256-2 1684946 704.1 ns/op 11.36 MB/s 0 B/op 0 allocs/op
BenchmarkHash1K/New-2 121077 9845 ns/op 104.02 MB/s 0 B/op 0 allocs/op
BenchmarkHash1K/Sum224-2 120547 9880 ns/op 103.64 MB/s 0 B/op 0 allocs/op
BenchmarkHash1K/Sum256-2 121282 9890 ns/op 103.54 MB/s 0 B/op 0 allocs/op
BenchmarkHash8K/New-2 16238 73778 ns/op 111.04 MB/s 0 B/op 0 allocs/op
BenchmarkHash8K/Sum224-2 16306 73792 ns/op 111.01 MB/s 0 B/op 0 allocs/op
BenchmarkHash8K/Sum256-2 16172 73933 ns/op 110.80 MB/s 0 B/op 0 allocs/op
PASS
ok crypto/sha256 15.647sI believe Blake3 hash should be working faster here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Increase the required Go version to 1.21 and update all direct dependencies. This will finally allow using the maps and slices packages. I've also removed usages of sha256-simd similar to minio/minio-go#1958 .
Was the change previously discussed in an issue or on the forum?
No.
Checklist
[ ] I have added tests for all code changes.changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.