ls: Fix --ncdu output with path filters and fix disk size#4911
Merged
MichaelEischer merged 4 commits intorestic:masterfrom Jul 10, 2024
Merged
ls: Fix --ncdu output with path filters and fix disk size#4911MichaelEischer merged 4 commits intorestic:masterfrom
MichaelEischer merged 4 commits intorestic:masterfrom
Conversation
Ncdu expects a size in disk blocks. Round up to the next full block. Otherwise, small files with size below 255bytes would be rounded down to 0B by ncdu.
1c4ad76 to
5067a40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Fix the ncdu error from #4910 . The ncdu output was missing the intermediate directories that lead up to the specified paths. In addition, skipped subfolders were not rendered correctly.
ncdu rounds a disk size of below 255bytes down to zero. To prevent this from happening round up the disk size to the next full sector.
Was the change previously discussed in an issue or on the forum?
Fixes #4910.
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.