S3: Improve anonymous access#4908
Merged
MichaelEischer merged 4 commits intorestic:masterfrom Jul 10, 2024
Merged
Conversation
The default client has no timeouts configured opening network connections. Thus, if 169.254.169.254 is inaccessible, then the client would wait for until the operating system gives up, which will take several minutes.
830f9c0 to
3e835b9
Compare
3e835b9 to
dc0db4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Disallow S3 anonymous authentication unless explicitly requested. This prevents slowdowns as S3 IAM requests are not necessary when explicitly selecting anonymous authentication and avoids pointless reauthentication attempts.
Was the change previously discussed in an issue or on the forum?
Fixes #4707
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.