Skip to content

key add/passwd: handle UTF-16 encoding correctly#4851

Merged
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:fix-utf-16-key
Jun 9, 2024
Merged

key add/passwd: handle UTF-16 encoding correctly#4851
MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer:fix-utf-16-key

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer commented Jun 5, 2024

What does this PR change? What problem does it solve?

Just use the exact some function for load a password from a file everywhere.

Was the change previously discussed in an issue or on the forum?

Fixes #4850

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • [ ] I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Just use the exact some function for load a password from a file
everywhere.
Copy link
Copy Markdown
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelEischer MichaelEischer merged commit fc3841e into restic:master Jun 9, 2024
@MichaelEischer MichaelEischer deleted the fix-utf-16-key branch June 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect File Encoding Used When Adding Keys - Previously Added UTF-16 Key Files Cannot Be Used to Access the Repository

1 participant