Make restore overwrite behavior configurable#4837
Merged
MichaelEischer merged 14 commits intorestic:masterfrom Jun 12, 2024
Merged
Make restore overwrite behavior configurable#4837MichaelEischer merged 14 commits intorestic:masterfrom
MichaelEischer merged 14 commits intorestic:masterfrom
Conversation
This was referenced May 31, 2024
This get's rid of the corresponding special cases.
Loading blobs by now is no longer prone to timeouts when processing takes a long time.
4003510 to
7f7c995
Compare
MichaelEischer
commented
Jun 12, 2024
Member
Author
There was a problem hiding this comment.
LGTM. The --overwrite option name is not completely final yet. There's a chance it will be renamed to e.g. --policy skip|update-if-newer|update-if-changed|update-always suggested by @rawtaz.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The
restorecommand now supports an--overwriteoption to configure whether already existing files are overwritten. The default is--overwrite always, which overwrites existing files.--overwrite if-neweronly restores files from the snapshot that are newer than the local state. And--overwrite neverdoes not modify existing files.The
--overwriteoption replaces the--ignore-existingand--overwrite-if-newerflags from #4817 .Was the change previously discussed in an issue or on the forum?
Fixes #200.
See #4817 .
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.