Skip to content

feat: dump flag --target should be allowed to write existing file#4692

Merged
MichaelEischer merged 2 commits intorestic:masterfrom
27149chen:dump-to-existing-file
Feb 10, 2024
Merged

feat: dump flag --target should be allowed to write existing file#4692
MichaelEischer merged 2 commits intorestic:masterfrom
27149chen:dump-to-existing-file

Conversation

@27149chen
Copy link
Copy Markdown
Contributor

@27149chen 27149chen commented Feb 8, 2024

What does this PR change? What problem does it solve?

dump flag --target should be allowed to write existing file

The primary objective of #4678 is to restore a block PVC.
steps:

  1. mount the block pvc to a pod as volumeDevice
  2. start the pod, write data to the block device inside the pod using restic

The block device is already there, we need to use restic dump to write data into it

Was the change previously discussed in an issue or on the forum?

Closes #4678

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@27149chen 27149chen force-pushed the dump-to-existing-file branch from d6e871a to 2cfdc62 Compare February 8, 2024 06:19
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MichaelEischer MichaelEischer added this pull request to the merge queue Feb 10, 2024
Merged via the queue into restic:master with commit 68cc327 Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add --target flag to dump command

2 participants