Move key add, list, remove and passwd as separate sub-commands and improve key sub-command documentation#4685
Merged
MichaelEischer merged 2 commits intorestic:masterfrom Feb 8, 2024
Conversation
MichaelEischer
requested changes
Feb 5, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
Thanks for working on this! I like the change in general, but I found a few problems that were introduced while refactoring the code.
docs: improve the sub-command docs changelog: add the unreleased changelog for the key command updates key: update integration tests
7cdf988 to
795d33b
Compare
konidev20
commented
Feb 5, 2024
MichaelEischer
approved these changes
Feb 8, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM.
I've fixed the integration test. key list returned an error for the wrong reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Restic previously used command line args to figure out the command to be executed for the
keycommand. The documentation of the key command was limited.@MichaelEischer requested the key command to be split into their own sub-commands like how the
repaircommand is structured.This PR has split the
keycommand into their respective sub-commands using spf13/cobra's sub-command feature.Was the change previously discussed in an issue or on the forum?
Closes #4676
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.